linux-kernel - Re: [PATCH v4] vmstat: Kernel stack usage histogram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240723170913.07bfd0ba8a2557285263912e@linux-foundation.org>
Date: Tue, 23 Jul 2024 17:09:13 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Shakeel Butt <shakeel.butt@...ux.dev>
Cc: Pasha Tatashin <pasha.tatashin@...een.com>, jpoimboe@...nel.org,
 kent.overstreet@...ux.dev, peterz@...radead.org, nphamcs@...il.com,
 cerasuolodomenico@...il.com, surenb@...gle.com, lizhijian@...itsu.com,
 willy@...radead.org, vbabka@...e.cz, ziy@...dia.com,
 linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v4] vmstat: Kernel stack usage histogram

On Fri, 19 Jul 2024 15:04:40 -0700 Shakeel Butt <shakeel.butt@...ux.dev> wrote:

> > > Any specific reason to add this function in header?
> > 
> > For performance reasons to keep it inlined into stack_not_used() which
> > is also defined as inline function in this header.
> > 
> 
> Is this really that performance critical?

Nope.  stack_not_used() is for CONFIG_DEBUG_STACK_USAGE and
stack_not_used() is slow.

I suggest that stack_not_used() (and hence kstack_histogram()) be
uninlined.  This can be a followup patch.