linux-kernel - Re: [PATCH v2 17/16] xz: Remove XZ_EXTERN and extern from functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8734nzvu1x.fsf@mail.lhotse>
Date: Wed, 24 Jul 2024 22:44:10 +1000
From: Michael Ellerman <mpe@...erman.id.au>
To: Lasse Collin <lasse.collin@...aani.org>, Andrew Morton
 <akpm@...ux-foundation.org>
Cc: Lasse Collin <lasse.collin@...aani.org>, Sam James <sam@...too.org>,
 linux-kernel@...r.kernel.org, Jonathan Corbet <corbet@....net>,
 linuxppc-dev@...ts.ozlabs.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v2 17/16] xz: Remove XZ_EXTERN and extern from functions

Lasse Collin <lasse.collin@...aani.org> writes:
> XZ_EXTERN was used to make internal functions static in the preboot code.
> However, in other decompressors this hasn't been done. On x86-64, this
> makes no difference to the kernel image size.
>
> Omit XZ_EXTERN and let some of the internal functions be extern in the
> preboot code. Omitting XZ_EXTERN from include/linux/xz.h fixes warnings
> in "make htmldocs" and makes the intradocument links to xz_dec functions
> work in Documentation/staging/xz.rst. The alternative would have been to
> add "XZ_EXTERN" to c_id_attributes in Documentation/conf.py but omitting
> XZ_EXTERN seemed cleaner.
>
> Link: https://lore.kernel.org/lkml/20240723205437.3c0664b0@kaneli/
> Cc: Michael Ellerman <mpe@...erman.id.au>
> Cc: Jonathan Corbet <corbet@....net>
> Cc: linuxppc-dev@...ts.ozlabs.org
> Cc: linux-doc@...r.kernel.org
> Signed-off-by: Lasse Collin <lasse.collin@...aani.org>
> ---
>
> Notes:
>     This touches xz_config.h in PowerPC boot code. I haven't tested it but
>     zlib's functions are extern in the same context, thus this should be
>     a safe change on PowerPC.
     
I gave it a quick build and boot, seems fine.

Tested-by: Michael Ellerman <mpe@...erman.id.au> (powerpc)

cheers