linux-kernel - Re: [PATCH v2] of: remove internal arguments from of_property_for_each

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqKtOTgoDgfwq9Guvt_LbtnHHGJ+PDt-wgVRHU=oVzwhHw@mail.gmail.com>
Date: Wed, 24 Jul 2024 08:53:24 -0500
From: Rob Herring <robh@...nel.org>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>
Cc: Stephen Boyd <sboyd@...nel.org>, Aaro Koskinen <aaro.koskinen@....fi>, 
	Alexandre Belloni <alexandre.belloni@...tlin.com>, Alim Akhtar <alim.akhtar@...sung.com>, 
	Andreas Kemnade <andreas@...nade.info>, Bartosz Golaszewski <brgl@...ev.pl>, 
	Bjorn Andersson <andersson@...nel.org>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Chen-Yu Tsai <wens@...e.org>, 
	Chester Lin <chester62515@...il.com>, Christophe Leroy <christophe.leroy@...roup.eu>, 
	Claudiu Beznea <claudiu.beznea@...on.dev>, Damien Le Moal <dlemoal@...nel.org>, 
	Daniel Lezcano <daniel.lezcano@...aro.org>, Dong Aisheng <aisheng.dong@....com>, 
	Doug Berger <opendmb@...il.com>, Emilio López <emilio@...pez.com.ar>, 
	Fabio Estevam <festevam@...il.com>, Florian Fainelli <florian.fainelli@...adcom.com>, 
	Ghennadi Procopciuc <ghennadi.procopciuc@....nxp.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jacky Bai <ping.bai@....com>, 
	Jaroslav Kysela <perex@...ex.cz>, Jernej Skrabec <jernej.skrabec@...il.com>, 
	Jiri Slaby <jirislaby@...nel.org>, Jonathan Cameron <jic23@...nel.org>, 
	Kevin Hilman <khilman@...libre.com>, Krzysztof Kozlowski <krzk@...nel.org>, 
	Lars-Peter Clausen <lars@...afoo.de>, Lee Jones <lee@...nel.org>, Liam Girdwood <lgirdwood@...il.com>, 
	Linus Walleij <linus.walleij@...aro.org>, Mark Brown <broonie@...nel.org>, 
	Matthias Brugger <mbrugger@...e.com>, Michael Ellerman <mpe@...erman.id.au>, 
	Michael Turquette <mturquette@...libre.com>, Miguel Ojeda <ojeda@...nel.org>, 
	Nathan Chancellor <nathan@...nel.org>, "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>, 
	Nicholas Piggin <npiggin@...il.com>, Nicolas Ferre <nicolas.ferre@...rochip.com>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, Richard Leitner <richard.leitner@...ux.dev>, 
	Roger Quadros <rogerq@...nel.org>, Samuel Holland <samuel@...lland.org>, 
	Saravana Kannan <saravanak@...gle.com>, Shawn Guo <shawnguo@...nel.org>, 
	Takashi Iwai <tiwai@...e.com>, Thomas Gleixner <tglx@...utronix.de>, Tony Lindgren <tony@...mide.com>, 
	Uwe Kleine-König <ukleinek@...nel.org>, 
	"Peng Fan (OSS)" <peng.fan@....nxp.com>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	llvm@...ts.linux.dev, linux-clk@...r.kernel.org, linux-omap@...r.kernel.org, 
	linux-arm-msm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-sunxi@...ts.linux.dev, linux-samsung-soc@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-iio@...r.kernel.org, 
	linux-pwm@...r.kernel.org, linux-serial@...r.kernel.org, 
	linux-usb@...r.kernel.org, patches@...nsource.cirrus.com, 
	linux-sound@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, 
	linux-riscv@...ts.infradead.org, Andre Przywara <andre.przywara@....com>, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>, 
	Jonathan Cameron <Jonathan.Cameron@...wei.com>, 
	Uwe Kleine-König <u.kleine-koenig@...libre.com>, 
	Richard Fitzgerald <rf@...nsource.cirrus.com>
Subject: Re: [PATCH v2] of: remove internal arguments from of_property_for_each_u32()

On Thu, Jul 18, 2024 at 1:57 AM Luca Ceresoli <luca.ceresoli@...tlin.com> wrote:
>
> Hello Stephen,
>
> On Wed, 17 Jul 2024 16:33:34 -0700
> Stephen Boyd <sboyd@...nel.org> wrote:
>
> > > @@ -1191,20 +1191,24 @@ static int si5351_dt_parse(struct i2c_client *client,
> > >          * property silabs,pll-source : <num src>, [<..>]
> > >          * allow to selectively set pll source
> > >          */
> > > -       of_property_for_each_u32(np, "silabs,pll-source", prop, p, num) {
> > > +       sz = of_property_read_variable_u32_array(np, "silabs,pll-source", array, 2, 4);
> > > +       sz = (sz == -EINVAL) ? 0 : sz; /* Missing property is OK */
> > > +       if (sz < 0)
> > > +               return dev_err_probe(&client->dev, sz, "invalid pll-source");
> >
> > Needs a newline on the printk message.
>
> Ouch! Fix queued for v3.

I need v3 like today if I'm going to send it for rc1.

Rob