[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <2024072418-vitalize-resurface-1d40@gregkh>
Date: Wed, 24 Jul 2024 16:06:30 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Zijun Hu <zijun_hu@...oud.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, linux-kernel@...r.kernel.org,
Zijun Hu <quic_zijuhu@...cinc.com>
Subject: Re: [PATCH v2] driver core: bus: Return -EIO instead of 0 when
show/store invalid bus attribute
On Wed, Jul 24, 2024 at 09:54:48PM +0800, Zijun Hu wrote:
> From: Zijun Hu <quic_zijuhu@...cinc.com>
>
> Return -EIO instead of 0 for below erroneous bus attribute operations:
> - read a bus attribute without show().
> - write a bus attribute without store().
>
> Signed-off-by: Zijun Hu <quic_zijuhu@...cinc.com>
> ---
> Changes in v2:
> - Correct commit messages and add inline comments
> - The following commit have similar change
> Commit: 4a0c20bf8c0f ("[PATCH] sysfs: (driver/base) if show/store is missing return -EIO")
> - Link to v1: https://lore.kernel.org/r/20240723-bus_fix-v1-1-175f926805dc@quicinc.com
> ---
> drivers/base/bus.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Again, how was this tested?
thanks,
greg k-h
Powered by blists - more mailing lists