[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <e9b2d908-5a48-4c4a-b7e4-d82e36ecf143@redhat.com>
Date: Wed, 24 Jul 2024 16:14:11 +0200
From: David Hildenbrand <david@...hat.com>
To: Zi Yan <ziy@...dia.com>, Andrew Morton <akpm@...ux-foundation.org>,
linux-mm@...ck.org
Cc: "Huang, Ying" <ying.huang@...el.com>,
Baolin Wang <baolin.wang@...ux.alibaba.com>,
Kefeng Wang <wangkefeng.wang@...wei.com>,
Lorenzo Stoakes <lorenzo.stoakes@...cle.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/3] memory tiering: count PGPROMOTE_SUCCESS when mem
tiering is enabled.
On 24.07.24 15:01, Zi Yan wrote:
> memory tiering can be enabled/disabled at runtime and
> sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING is used to check
> it. In migrate_misplaced_folio(), the check is missing when
> PGPROMOTE_SUCCESS is incremented. Add the missing check.
>
> Reported-by: Kefeng Wang <wangkefeng.wang@...wei.com>
> Closes: https://lore.kernel.org/linux-mm/f4ae2c9c-fe40-4807-bdb2-64cf2d716c1a@huawei.com/
> Fixes: 33024536bafd ("memory tiering: hot page selection with hint page fault latency")
> Signed-off-by: Zi Yan <ziy@...dia.com>
> ---
> mm/migrate.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/mm/migrate.c b/mm/migrate.c
> index e7296c0fb5d5..826afb82ca56 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -2630,7 +2630,9 @@ int migrate_misplaced_folio(struct folio *folio, struct vm_area_struct *vma,
> putback_movable_pages(&migratepages);
> if (nr_succeeded) {
> count_vm_numa_events(NUMA_PAGE_MIGRATE, nr_succeeded);
> - if (!node_is_toptier(folio_nid(folio)) && node_is_toptier(node))
> + if ((sysctl_numa_balancing_mode & NUMA_BALANCING_MEMORY_TIERING)
> + && !node_is_toptier(folio_nid(folio))
> + && node_is_toptier(node))
> mod_node_page_state(pgdat, PGPROMOTE_SUCCESS,
> nr_succeeded);
> }
Acked-by: David Hildenbrand <david@...hat.com>
--
Cheers,
David / dhildenb
Powered by blists - more mailing lists