linux-kernel - Re: [PATCH] perf scripts python: cs-etm: Update example to provide vmlinux path to Perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <918e5562-1523-4793-93c7-94ee143ff87c@arm.com>
Date: Wed, 24 Jul 2024 16:35:50 +0100
From: Leo Yan <leo.yan@....com>
To: James Clark <james.clark@...aro.org>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
 Arnaldo Carvalho de Melo <acme@...nel.org>,
 Namhyung Kim <namhyung@...nel.org>, Mark Rutland <mark.rutland@....com>,
 Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
 Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
 Adrian Hunter <adrian.hunter@...el.com>,
 "Liang, Kan" <kan.liang@...ux.intel.com>,
 Ruidong Tian <tianruidong@...ux.alibaba.com>,
 Benjamin Gray <bgray@...ux.ibm.com>, linux-perf-users@...r.kernel.org,
 linux-kernel@...r.kernel.org, coresight@...ts.linaro.org,
 gankulkarni@...amperecomputing.com, mike.leach@...aro.org,
 suzuki.poulose@....com
Subject: Re: [PATCH] perf scripts python: cs-etm: Update example to provide
 vmlinux path to Perf

On 7/24/2024 4:23 PM, James Clark wrote:

[...]

>> The change makes senses to me.  Just check a bit, does it need to add the same
>> option for the command "only source line and symbols"?
> 
> I assumed that because that one didn't have vmlinux at all then it's
> just for userspace tracing.
For the only source and symbols case, I expect it will can be used for kernel
tracing as well, as this can save much time if someone doesn't care about
disassembly.

Maybe it is good to add the same option for it, even though it is not used for
user space tracing. Either is fine for me:

Reviewed-by: Leo Yan <leo.yan@....com>

> I think it's good to have an example without
> vmlinux to show that it's not a strict requirement.

>>> ---
>>>   tools/perf/scripts/python/arm-cs-trace-disasm.py | 4 ++--
>>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/tools/perf/scripts/python/arm-cs-trace-disasm.py
>>> b/tools/perf/scripts/python/arm-cs-trace-disasm.py
>>> index 7aff02d84ffb..4aeb9b497f7a 100755
>>> --- a/tools/perf/scripts/python/arm-cs-trace-disasm.py
>>> +++ b/tools/perf/scripts/python/arm-cs-trace-disasm.py
>>> @@ -19,10 +19,10 @@ from perf_trace_context import perf_set_itrace_options, \
>>>   # Below are some example commands for using this script.
>>>   #
>>>   # Output disassembly with objdump:
>>> -#  perf script -s scripts/python/arm-cs-trace-disasm.py \
>>> +#  perf script -k path/to/vmlinux -s scripts/python/arm-cs-trace-disasm.py \
>>>   #              -- -d objdump -k path/to/vmlinux
>>>   # Output disassembly with llvm-objdump:
>>> -#  perf script -s scripts/python/arm-cs-trace-disasm.py \
>>> +#  perf script -k path/to/vmlinux -s scripts/python/arm-cs-trace-disasm.py \
>>>   #              -- -d llvm-objdump-11 -k path/to/vmlinux
>>>   # Output only source line and symbols:
>>>   #  perf script -s scripts/python/arm-cs-trace-disasm.py
>>> -- 
>>> 2.34.1
>>>