linux-kernel - Re: [PATCH] dt-bindings: iio: adc: ad7192: Fix 'single-channel' constraints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240724-graveyard-outshine-a53d36367655@spud>
Date: Wed, 24 Jul 2024 17:42:18 +0100
From: Conor Dooley <conor@...nel.org>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Alisa-Dariana Roman <alisa.roman@...log.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Alisa-Dariana Roman <alisadariana@...il.com>,
	Conor Dooley <conor.dooley@...rochip.com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: adc: ad7192: Fix 'single-channel'
 constraints

On Tue, Jul 23, 2024 at 06:09:03PM -0500, Rob Herring (Arm) wrote:
> The 'single-channel' property is an uint32, not an array, so 'items' is
> an incorrect constraint. This didn't matter until dtschema recently
> changed how properties are decoded. This results in this warning:
> 
> Documentation/devicetree/bindings/iio/adc/adi,ad7192.example.dtb: adc@0: \
>   channel@1:single-channel: 1 is not of type 'array'
> 
> Fixes: caf7b7632b8d ("dt-bindings: iio: adc: ad7192: Add AD7194 support")

Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

> Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> ---
>  Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> index a03da9489ed9..190889c7b62a 100644
> --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7192.yaml
> @@ -120,9 +120,8 @@ patternProperties:
>          description:
>            Positive input can be connected to pins AIN1 to AIN16 by choosing the
>            appropriate value from 1 to 16. Negative input is connected to AINCOM.
> -        items:
> -          minimum: 1
> -          maximum: 16
> +        minimum: 1
> +        maximum: 16
>  
>      oneOf:
>        - required:
> -- 
> 2.43.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)