linux-kernel - Re: [PATCH 0/2] Remove PG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=wh4_5KdXq9HoA6L_Oy3vgCo8eAFAMNMmO9eBJgu9sW6QA@mail.gmail.com>
Date: Wed, 24 Jul 2024 10:04:46 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: "Matthew Wilcox (Oracle)" <willy@...radead.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, 
	linux-mm@...ck.org
Subject: Re: [PATCH 0/2] Remove PG_error

On Tue, 23 Jul 2024 at 18:05, Matthew Wilcox (Oracle)
<willy@...radead.org> wrote:
>
> There were four pulls I had to wait for before I could send this to you,
> but PG_error is now unused and can be reclaimed.  It could wait until
> next merge window, but I don't see the point.

Well, I was initially inclined to agree with that, but then I did a
test-compile, and that immediately notices that you never tested this
at all and that it's completely broken.

There's still uses of PG_error in fs/proc/page.c, and in
include/trace/events/mmflags.h, and neither of those two cases are
new. One is unchanged from 2009, and the other one has gone through a
few code movements and re-orgs but also goes back over a decade ago.

So clearly this needs to be in linux-next, and as such this very much
is "next merge window".

                 Linus