[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<ZQ0PR01MB1302D6D18B2EE5B8BA4828E8F2AA2@ZQ0PR01MB1302.CHNPR01.prod.partner.outlook.cn>
Date: Wed, 24 Jul 2024 01:40:19 +0000
From: Changhuang Liang <changhuang.liang@...rfivetech.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC: Mauro Carvalho Chehab <mchehab@...nel.org>, Greg Kroah-Hartman
<gregkh@...uxfoundation.org>, Sakari Ailus <sakari.ailus@...ux.intel.com>,
Hans Verkuil <hverkuil-cisco@...all.nl>, Jean-Michel Hautbois
<jeanmichel.hautbois@...asonboard.com>, Benjamin Gaignard
<benjamin.gaignard@...labora.com>, Tomi Valkeinen
<tomi.valkeinen+renesas@...asonboard.com>, Mingjia Zhang
<mingjia.zhang@...iatek.com>, Jack Zhu <jack.zhu@...rfivetech.com>, Keith
Zhao <keith.zhao@...rfivetech.com>, "linux-media@...r.kernel.org"
<linux-media@...r.kernel.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "linux-staging@...ts.linux.dev"
<linux-staging@...ts.linux.dev>
Subject:
回复: [PATCH v5 14/14] admin-guide: media: Update documents for StarFive Camera Subsystem
Hi, Laurent
Thanks for your comments.
> Hi Changhuang,
>
> Thank you for the patch.
>
> On Tue, Jul 09, 2024 at 01:38:24AM -0700, Changhuang Liang wrote:
> > Add ISP output parameters and 3A statistisc collection data video
> > device for documents.
> >
> > Signed-off-by: Changhuang Liang <changhuang.liang@...rfivetech.com>
> > ---
> > .../admin-guide/media/starfive_camss.rst | 11 +++++++---
> > .../media/starfive_camss_graph.dot | 22
> +++++++++++--------
> > 2 files changed, 21 insertions(+), 12 deletions(-)
> >
> > diff --git a/Documentation/admin-guide/media/starfive_camss.rst
> > b/Documentation/admin-guide/media/starfive_camss.rst
> > index ca42e9447c47..020f1969e67f 100644
> > --- a/Documentation/admin-guide/media/starfive_camss.rst
> > +++ b/Documentation/admin-guide/media/starfive_camss.rst
> > @@ -58,15 +58,20 @@ The media controller pipeline graph is as follows:
> > :alt: starfive_camss_graph.dot
> > :align: center
> >
> > -The driver has 2 video devices:
> > +The driver has 4 video devices:
> >
> > +- output_params: The meta output device, transmitting the parameters
> > +to ISP
> > + module.
> > - capture_raw: The capture device, capturing image data directly from a
> sensor.
> > - capture_yuv: The capture device, capturing YUV frame data processed
> > by the
> > - ISP module
> > + ISP module.
> > +- capture_scd: The meta capture device, capturing 3A statistics
> > +collection data
>
> Renaming "scd" to "stats" (here and through the whole series) would make
> the code and documentation easier to understand for third parties, as it's not
> immediately clear what "scd" means. I won't insist too much if this would
> cause lots of issues.
>
Agreed, I will change this.
Regards,
Changhuang
Powered by blists - more mailing lists