linux-kernel - Re: [PATCH] drm/amd/display: Fix documentation warning for mpc.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_MHtyUENJGk=f+i-3ODJpGiZc1QFpQuvAh=uaFc9x9-9A@mail.gmail.com>
Date: Thu, 25 Jul 2024 15:54:42 -0400
From: Alex Deucher <alexdeucher@...il.com>
To: "Ricardo B. Marliere" <rbmarliere@...il.com>
Cc: Abhishek Tamboli <abhishektamboli9@...il.com>, airlied@...il.com, daniel@...ll.ch, 
	harry.wentland@....com, sunpeng.li@....com, Rodrigo.Siqueira@....com, 
	alexander.deucher@....com, christian.koenig@....com, Xinhui.Pan@....com, 
	amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org, 
	linux-kernel@...r.kernel.org, skhan@...uxfoundation.org, 
	marcelomspessoto@...il.com, aurabindo.pillai@....com, adnelson@....com, 
	linux-kernel-mentees@...ts.linuxfoundation.org
Subject: Re: [PATCH] drm/amd/display: Fix documentation warning for mpc.h

This is already fixed in:
https://gitlab.freedesktop.org/agd5f/linux/-/commit/6e169c7e0f842c48c7bf683fb789dbf5a8b1dfd8

Alex

On Wed, Jul 24, 2024 at 3:55 PM Ricardo B. Marliere
<rbmarliere@...il.com> wrote:
>
> On 24 Jul 24 23:24, Abhishek Tamboli wrote:
> > Fix documentation compile warning by adding description
> > for program_3dlut_size function.
> >
> > Remove the following warning:
> > ./drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h:1043: warning: Function parameter or struct member 'program_3dlut_size' not described in 'mpc_funcs'
> >
> > Signed-off-by: Abhishek Tamboli <abhishektamboli9@...il.com>
> > ---
> >  drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h | 16 +++++++++++++++-
> >  1 file changed, 15 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h b/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h
> > index 40a9b3471208..615c69d966e7 100644
> > --- a/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h
> > +++ b/drivers/gpu/drm/amd/display/dc/inc/hw/mpc.h
> > @@ -1039,7 +1039,21 @@ struct mpc_funcs {
> >       */
> >       void (*program_lut_mode)(struct mpc *mpc, const enum MCM_LUT_ID id, const enum MCM_LUT_XABLE xable,
> >                       bool lut_bank_a, int mpcc_id);
> > -     void (*program_3dlut_size)(struct mpc *mpc, bool is_17x17x17, int mpcc_id);
> > +     /**
> > +      * @program_3dlut_size:
> > +      *
> > +      * Program 3D LUT size.
> > +      *
> > +      * Parameters:
> > +      * - [in/out] mpc - MPC context.
> > +      * - [in] is_17x17x17 - Boolean Flag.
> > +      * - [in] mpcc_id - MPCC physical instance.
> > +      *
> > +      * Return:
> > +      *
> > +      * void
> > +      */
>
> Reviewed-by: Ricardo B. Marliere <ricardo@...liere.net>
>
>
> > +      void (*program_3dlut_size)(struct mpc *mpc, bool is_17x17x17, int mpcc_id);
> >  };
> >
> >  #endif
> > --
> > 2.34.1
> >