linux-kernel - Re: [PATCH] mm: Capitalize letters for readability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240725132124.b0d317ba1d9e7d1651b71a65@linux-foundation.org>
Date: Thu, 25 Jul 2024 13:21:24 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Steven Davis <goldside000@...look.com>
Cc: urezki@...il.com, hch@...radead.org, hannes@...xchg.org,
 yosryahmed@...gle.com, nphamcs@...il.com, chengming.zhou@...ux.dev,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: Capitalize letters for readability

On Thu, 25 Jul 2024 15:28:29 -0400 Steven Davis <goldside000@...look.com> wrote:

> This patch capitalizes the first letters of error and
> debug messages to enhance readability. This is important
> for adhering to the style of other error messages in the
> kernel, and making it easier and clearer to read the 
> messages upon the (likely dark) terminal.

hm.

x1:/usr/src/25> grep "  pr_[^(]*.*: [A-Z]" mm/*.c | wc -l
34
x1:/usr/src/25> grep "  pr_[^(]*.*: [a-z]" mm/*.c | wc -l 
97

If we're going to make this change then we should change everything,
add a checkpatch rule, etc.

But I do think such a change is too trivial to justify churning the
code around.