linux-kernel - Re: [PATCH] PCI: j721e: Set .map_irq and .swizzle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240725211941.GA860190@bhelgaas>
Date: Thu, 25 Jul 2024 16:19:41 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Siddharth Vadapalli <s-vadapalli@...com>
Cc: bhelgaas@...gle.com, lpieralisi@...nel.org, kw@...ux.com,
	robh@...nel.org, vigneshr@...com, kishon@...nel.org,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, stable@...r.kernel.org,
	ahalaney@...hat.com, srk@...com
Subject: Re: [PATCH] PCI: j721e: Set .map_irq and .swizzle_irq to NULL

On Thu, Jul 25, 2024 at 11:23:43AM +0530, Siddharth Vadapalli wrote:
> On Wed, Jul 24, 2024 at 11:23:04AM -0500, Bjorn Helgaas wrote:
> > Subject should say something about why this change is needed, not just
> > translate the C code to English.
> 
> My intent was to summarize the change to make it easy for anyone to find
> out what's being done. The commit message below explains in detail as to
> why they are set to NULL. As an alternative, I could change the $subject
> to:
> PCI: j721e: Disable INTx mapping and swizzling
> where the "Disable" is equivalent to NULL. Kindly let me know if this is
> acceptable or needs to be improved further.

Sounds fine to me.