linux-kernel - Re: [PATCH 1/2] PCI: endpoint: Introduce 'get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c76b9b4-9983-4389-bacb-ef4a5a8e7043@kernel.org>
Date: Fri, 26 Jul 2024 07:53:54 +0900
From: Damien Le Moal <dlemoal@...nel.org>
To: Niklas Cassel <cassel@...nel.org>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc: Rick Wertenbroek <rick.wertenbroek@...il.com>,
 rick.wertenbroek@...g-vd.ch, alberto.dassatti@...g-vd.ch,
 Krzysztof Wilczyński <kw@...ux.com>,
 Kishon Vijay Abraham I <kishon@...nel.org>,
 Bjorn Helgaas <bhelgaas@...gle.com>, Frank Li <Frank.Li@....com>,
 Lars-Peter Clausen <lars@...afoo.de>, linux-pci@...r.kernel.org,
 linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 1/2] PCI: endpoint: Introduce 'get_bar' to map fixed
 address BARs in EPC

On 7/26/24 06:52, Niklas Cassel wrote:
> On Thu, Jul 25, 2024 at 10:06:52PM +0530, Manivannan Sadhasivam wrote:
>>
>> I vary with you here. IMO EPF drivers have no business in knowing the BAR
>> location as they are independent of controller (mostly except drivers like MHI).
>> So an EPF driver should call a single API that just allocates/configures the
>> BAR. For fixed address BAR, EPC core should be able to figure it out using the
>> EPC features.
>>
>> For naming, we have 3 proposals as of now:
>>
>> 1. pci_epf_setup_bar() - This looks good, but somewhat collides with the
>> existing pci_epc_set_bar() API.
>>
>> 2. pci_epc_alloc_set_bar() - Looks ugly, but aligns with the existing APIs.
>>
>> 3. pci_epc_get_bar() - Also looks good, but the usage of 'get' gives the
>> impression that the BAR is fetched from somewhere, which is true for fixed
>> address BAR, but not for dynamic BAR.
> 
> pci_epc_configure_bar() ?
> we could name the 'struct pci_epf_bar *' param 'conf'

+1

But let's spell this out: pci_epc_configure_bar(), to be sure to avoid any
possible confusion (config could mean configure or configuration...).

-- 
Damien Le Moal
Western Digital Research