linux-kernel - Re: [PATCH v2 4/4] usb: typec: ucsi: Fix SET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <qjtutodlbqhsj3ofdhhw2ggjgh3sqglvxmxt72oz3j3xsswmau@g4b5ub56ctfl>
Date: Thu, 25 Jul 2024 06:51:16 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Jameson Thies <jthies@...gle.com>
Cc: heikki.krogerus@...ux.intel.com, linux-usb@...r.kernel.org, 
	bleung@...gle.com, abhishekpandit@...omium.org, andersson@...nel.org, 
	fabrice.gasnier@...s.st.com, gregkh@...uxfoundation.org, hdegoede@...hat.com, 
	neil.armstrong@...aro.org, rajaram.regupathy@...el.com, saranya.gopal@...el.com, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 4/4] usb: typec: ucsi: Fix SET_PDR typo in UCSI header
 file

On Wed, Jul 24, 2024 at 08:11:16PM GMT, Jameson Thies wrote:
> Fix SET_PDR typo in UCSI header file.
> 
> Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>
> Signed-off-by: Jameson Thies <jthies@...gle.com>
> ---
> Changes in V2:
> - None.

Fixes: 470ce43a1a81 ("usb: typec: ucsi: Remove struct ucsi_control")

Note, fixes patches should come before the rest of the changes.

> 
>  drivers/usb/typec/ucsi/ucsi.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/ucsi/ucsi.h b/drivers/usb/typec/ucsi/ucsi.h
> index 6a958eac5703..a0e91335da80 100644
> --- a/drivers/usb/typec/ucsi/ucsi.h
> +++ b/drivers/usb/typec/ucsi/ucsi.h
> @@ -153,7 +153,7 @@ void ucsi_connector_change(struct ucsi *ucsi, u8 num);
>  #define UCSI_SET_UOR_ROLE(_r_)		(((_r_) == TYPEC_HOST ? 1 : 2) << 23)
>  #define UCSI_SET_UOR_ACCEPT_ROLE_SWAPS		BIT(25)
>  
> -/* SET_PDF command bits */
> +/* SET_PDR command bits */
>  #define UCSI_SET_PDR_ROLE(_r_)		(((_r_) == TYPEC_SOURCE ? 1 : 2) << 23)
>  #define UCSI_SET_PDR_ACCEPT_ROLE_SWAPS		BIT(25)
>  
> -- 
> 2.45.2.1089.g2a221341d9-goog
> 

-- 
With best wishes
Dmitry