linux-kernel - Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 SoC CMU bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e31a69d9-0cdb-4e5f-9227-c7790538f55d@kernel.org>
Date: Thu, 25 Jul 2024 09:31:53 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "sunyeal.hong" <sunyeal.hong@...sung.com>, 'Rob Herring' <robh@...nel.org>
Cc: 'Sylwester Nawrocki' <s.nawrocki@...sung.com>,
 'Chanwoo Choi' <cw00.choi@...sung.com>,
 'Alim Akhtar' <alim.akhtar@...sung.com>,
 'Michael Turquette' <mturquette@...libre.com>,
 'Stephen Boyd' <sboyd@...nel.org>, 'Conor Dooley' <conor+dt@...nel.org>,
 linux-samsung-soc@...r.kernel.org, linux-clk@...r.kernel.org,
 devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 SoC CMU
 bindings

On 25/07/2024 09:14, sunyeal.hong wrote:
> Hello Krzysztof,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@...nel.org>
>> Sent: Thursday, July 25, 2024 3:41 PM
>> To: sunyeal.hong <sunyeal.hong@...sung.com>; 'Rob Herring'
>> <robh@...nel.org>
>> Cc: 'Sylwester Nawrocki' <s.nawrocki@...sung.com>; 'Chanwoo Choi'
>> <cw00.choi@...sung.com>; 'Alim Akhtar' <alim.akhtar@...sung.com>; 'Michael
>> Turquette' <mturquette@...libre.com>; 'Stephen Boyd' <sboyd@...nel.org>;
>> 'Conor Dooley' <conor+dt@...nel.org>; linux-samsung-soc@...r.kernel.org;
>> linux-clk@...r.kernel.org; devicetree@...r.kernel.org; linux-arm-
>> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
>> Subject: Re: [PATCH v4 1/4] dt-bindings: clock: add ExynosAuto v920 SoC
>> CMU bindings
>>
>> On 25/07/2024 08:37, Krzysztof Kozlowski wrote:
>>>>   then:
>>>>     properties:
>>>>       clocks:
>>>>         items:
>>>>           - description: External reference clock (38.4 MHz)
>>>>           - description: CMU_MISC NOC clock (from CMU_MISC)
>>>>
>>>>       clock-names:
>>>>         items:
>>>>           - const: oscclk
>>>>           - const: noc
>>>>
>>>> If there is anything I misunderstand, please guide me.
>>>>
>>>
>>> You did not address my questions at all instead just copied again the
>>> same. It is not how it works.
>>>
>>> I am not going to discuss like this.
>>
>> And in case it is still unclear - just look at your bindings and DTS.
>> They say you have three clocks!
>>
>> Best regards,
>> Krzysztof
>>
> 
> Let me answer your questions first.
> In the existing V4 patch, clock items were declared in if then for each block, so there was no problem.

No. Again, look at your binding and DTS.

1. What clocks did you define for cmu-top?
2. What clocks did you define for cmu-peric0?

Rob's advice is reasonable and you must follow it, unless you are not
telling us something. There is no other choice, no other compatibles, no
other devices.

> If modified according to Rob's comment, problems may occur as the input clock is configured differently for each block.

But it is not! Look at your binding.


Best regards,
Krzysztof