[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <172189304588.827855.15843679475980331109.b4-ty@kernel.org>
Date: Thu, 25 Jul 2024 08:37:25 +0100
From: Lee Jones <lee@...nel.org>
To: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>,
Jack Chen <zenghuchen@...gle.com>
Cc: Mark Brown <broonie@...nel.org>, Vadim Pasternak <vadimp@...dia.com>,
Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org,
linux-leds@...r.kernel.org
Subject: Re: (subset) [PATCH v2] leds: lm3601x: Calculate max_brightness
and brightness properly
On Thu, 04 Jul 2024 15:15:00 -0400, Jack Chen wrote:
> The torch_current_max should be checked not exceeding the upper bound.
> If it does, throw a warning message and set to LM3601X_MAX_TORCH_I_UA.
>
> LM3601x torch brigthness register (LM3601X_LED_TORCH_REG) takes 0 as the
> minimum output (2.4 mA). However, 0 of led_brightness means LED_OFF.
> Adding a -1 offset to brightness before writing to brightness
> register, so when users write minimum brightness (1), it sets lm3601x
> output the minimum.
>
> [...]
Applied, thanks!
[1/1] leds: lm3601x: Calculate max_brightness and brightness properly
commit: ef23c7b35efb9cfa0b56fbb7fdf3aa782b1c2b87
--
Lee Jones [李琼斯]
Powered by blists - more mailing lists