linux-kernel - Re: [PATCH] irqchip: Replace compared GIC version with ID_AA64PFR0_EL1_GIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55f28eae-3883-4364-9b7e-3bf7645c0d5c@arm.com>
Date: Thu, 25 Jul 2024 13:58:10 +0530
From: Anshuman Khandual <anshuman.khandual@....com>
To: Marc Zyngier <maz@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org, Thomas Gleixner
 <tglx@...utronix.de>, Catalin Marinas <catalin.marinas@....com>,
 Will Deacon <will@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] irqchip: Replace compared GIC version with
 ID_AA64PFR0_EL1_GIC_V4P1



On 7/24/24 20:06, Marc Zyngier wrote:
> On Wed, 24 Jul 2024 06:46:23 +0100,
> Anshuman Khandual <anshuman.khandual@....com> wrote:
>>
>> Replace open encoding for GIC version code with ID_AA64PFR0_EL1_GIC_V4P1 in
>> gic_cpuif_has_vsgi().
> 
> Please fix the subject format to say "irqchip/gic-v4.1".

Sure, will change as suggested.

> 
>>
>> Cc: Marc Zyngier <maz@...nel.org>
>> Cc: Thomas Gleixner <tglx@...utronix.de>
>> Cc: Catalin Marinas <catalin.marinas@....com>
>> Cc: Will Deacon <will@...nel.org>
>> Cc: linux-arm-kernel@...ts.infradead.org
>> Cc: linux-kernel@...r.kernel.org
>> Signed-off-by: Anshuman Khandual <anshuman.khandual@....com>
>> ---
>> Applies after the following patch that fixes the given field in tools sysreg.
>>
>> https://lore.kernel.org/all/20240718215532.616447-1-rananta@google.com/
>>
>>  drivers/irqchip/irq-gic-v4.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/irq-gic-v4.c b/drivers/irqchip/irq-gic-v4.c
>> index ca32ac19d284..58c28895f8c4 100644
>> --- a/drivers/irqchip/irq-gic-v4.c
>> +++ b/drivers/irqchip/irq-gic-v4.c
>> @@ -97,7 +97,7 @@ bool gic_cpuif_has_vsgi(void)
>>  
>>  	fld = cpuid_feature_extract_unsigned_field(reg, ID_AA64PFR0_EL1_GIC_SHIFT);
>>  
>> -	return fld >= 0x3;
>> +	return fld >= ID_AA64PFR0_EL1_GIC_V4P1;
>>  }
>>  #else
>>  bool gic_cpuif_has_vsgi(void)
> 
> Please repost this *once* the dependent patch is actually merged, so
> that we don't have to think of the dependencies.

Sure, will do that.

> 
> With that:
> 
> Acked-by: Marc Zyngier <maz@...nel.org>
> 
> 	M.
>