[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ae465-66a21f00-1-25170f80@209442668>
Date: Thu, 25 Jul 2024 10:46:51 +0100
From: "Shreeya Patel" <shreeya.patel@...labora.com>
To: "Rob Herring (Arm)" <robh@...nel.org>
Cc: kernel@...labora.com, mchehab@...nel.org, conor+dt@...nel.org, linux-media@...r.kernel.org, nelson.costa@...opsys.com, linux-arm-kernel@...ts.infradead.org, heiko@...ech.de, mturquette@...libre.com, hverkuil@...all.nl, hverkuil-cisco@...all.nl, linux-rockchip@...ts.infradead.org, shawn.wen@...k-chips.com, sboyd@...nel.org, "Dmitry Osipenko" <dmitry.osipenko@...labora.com>, p.zabel@...gutronix.de, jose.abreu@...opsys.com, linux-kernel@...r.kernel.org, krzk+dt@...nel.org, devicetree@...r.kernel.org, nicolas.dufresne@...labora.com
Subject: Re: [PATCH v4 2/4] dt-bindings: media: Document bindings for HDMI RX Controller
On Saturday, July 20, 2024 03:40 IST, "Rob Herring (Arm)" <robh@...nel.org> wrote:
>
> On Fri, 19 Jul 2024 18:10:30 +0530, Shreeya Patel wrote:
> > Document bindings for the Synopsys DesignWare HDMI RX Controller.
> >
> > Reviewed-by: Rob Herring <robh@...nel.org>
> > Reviewed-by: Dmitry Osipenko <dmitry.osipenko@...labora.com>
> > Signed-off-by: Shreeya Patel <shreeya.patel@...labora.com>
> > ---
> >
> > Changes in v4 :-
> > - No change
> >
> > Changes in v3 :-
> > - Rename hdmirx_cma to hdmi_receiver_cma
> > - Add a Reviewed-by tag
> >
> > Changes in v2 :-
> > - Add a description for the hardware
> > - Rename resets, vo1 grf and HPD properties
> > - Add a proper description for grf and vo1-grf phandles
> > - Rename the HDMI Input node name to hdmi-receiver
> > - Improve the subject line
> > - Include gpio header file in example to fix dt_binding_check failure
> >
> > .../bindings/media/snps,dw-hdmi-rx.yaml | 132 ++++++++++++++++++
> > 1 file changed, 132 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.yaml
> >
>
> My bot found errors running 'make dt_binding_check' on your patch:
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Error: Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.example.dts:53.38-39 syntax error
> FATAL ERROR: Unable to parse input tree
> make[2]: *** [scripts/Makefile.lib:427: Documentation/devicetree/bindings/media/snps,dw-hdmi-rx.example.dtb] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1430: dt_binding_check] Error 2
> make: *** [Makefile:240: __sub-make] Error 2
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240719124032.26852-3-shreeya.patel@collabora.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
My HDMI RX patches are based on the linux-next/master branch.
Since the bot tested the patches on top of rc1, it resulted in some errors
due to missing reset ID patches.
I think the above statement means I should explicitly mention in this
patch that it is based on linux-next/master (something to keep in mind
for future :)
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
> _______________________________________________
> Kernel mailing list -- kernel@...lman.collabora.com
> To unsubscribe send an email to kernel-leave@...lman.collabora.com
> This list is managed by https://mailman.collabora.com
Powered by blists - more mailing lists