[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d2014eb3-2cea-474a-8f04-a4251fd956c9@redhat.com>
Date: Thu, 25 Jul 2024 12:13:29 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Eric Dumazet <edumazet@...gle.com>, Shigeru Yoshida <syoshida@...hat.com>
Cc: davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] macvlan: Return error on
register_netdevice_notifier() failure
On 7/25/24 11:44, Eric Dumazet wrote:
> On Wed, Jul 24, 2024 at 3:56 PM Shigeru Yoshida <syoshida@...hat.com> wrote:
>>
>> register_netdevice_notifier() may fail, but macvlan_init_module() does
>> not handle the failure. Handle the failure by returning an error.
>
> How could this fail exactly ? Please provide details, because I do not
> think it can.
Yup, it looks like the registration can't fail for macvlan.
It's better to avoid adding unneeded checks, to reduce noise on the
tree, keep stable backport easy, etc.
Thanks,
Paolo
Powered by blists - more mailing lists