linux-kernel - Re: [PATCH v3 6/7] tools: separate out shared radix-tree components

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7aae7eb2-6170-4ed6-bee5-6a0c35294381@lucifer.local>
Date: Thu, 25 Jul 2024 11:20:27 +0100
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-mm@...ck.org, "Liam R . Howlett" <Liam.Howlett@...cle.com>,
        Vlastimil Babka <vbabka@...e.cz>, Matthew Wilcox <willy@...radead.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
        Eric Biederman <ebiederm@...ssion.com>, Kees Cook <kees@...nel.org>,
        Suren Baghdasaryan <surenb@...gle.com>, SeongJae Park <sj@...nel.org>,
        Shuah Khan <shuah@...nel.org>,
        Brendan Higgins <brendanhiggins@...gle.com>,
        David Gow <davidgow@...gle.com>, Rae Moar <rmoar@...gle.com>
Subject: Re: [PATCH v3 6/7] tools: separate out shared radix-tree components

On Mon, Jul 22, 2024 at 12:50:24PM GMT, Lorenzo Stoakes wrote:
> The core components contained within the radix-tree tests which provide
> shims for kernel headers and access to the maple tree are useful for
> testing other things, so separate them out and make the radix tree tests
> dependent on the shared components.
>
> This lays the groundwork for us to add VMA tests of the newly introduced
> vma.c file.
>
> Acked-by: Vlastimil Babka <vbabka@...e.cz>
> Reviewed-by: Liam R. Howlett <Liam.Howlett@...cle.com>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
> ---

[snip]

Andrew - we double-include a header, it has header guards so this has no impact, but
obviously should be fixed for neatness.

----8<----
from 1bbb39c83aaee80b32d7ab0f26caff0def2dd969 Mon Sep 17 00:00:00 2001
From: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Date: Thu, 25 Jul 2024 10:47:40 +0100
Subject: [PATCH] tools: fix double header include

We already imported the stubbed-out linux/types.h. This has no impact as it
has a header guards but let's clean this up.

Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
---
 tools/testing/shared/shared.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/testing/shared/shared.h b/tools/testing/shared/shared.h
index 495602e60b65..f08f683812ad 100644
--- a/tools/testing/shared/shared.h
+++ b/tools/testing/shared/shared.h
@@ -6,7 +6,6 @@
 #include <linux/bitops.h>

 #include <linux/gfp.h>
-#include <linux/types.h>
 #include <linux/rcupdate.h>

 #ifndef module_init
--
2.45.2