linux-kernel - Re: [PATCH net v3] tcp: process the 3rd ACK with sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <172190583169.25674.14447045356080630577.git-patchwork-notify@kernel.org>
Date: Thu, 25 Jul 2024 11:10:31 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Matthieu Baerts (NGI0) <matttbe@...nel.org>
Cc: edumazet@...gle.com, davem@...emloft.net, dsahern@...nel.org,
 kuba@...nel.org, pabeni@...hat.com, kuniyu@...zon.com, ncardwell@...gle.com,
 netdev@...r.kernel.org, mptcp@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v3] tcp: process the 3rd ACK with sk_socket for
 TFO/MPTCP

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@...hat.com>:

On Wed, 24 Jul 2024 12:25:16 +0200 you wrote:
> The 'Fixes' commit recently changed the behaviour of TCP by skipping the
> processing of the 3rd ACK when a sk->sk_socket is set. The goal was to
> skip tcp_ack_snd_check() in tcp_rcv_state_process() not to send an
> unnecessary ACK in case of simultaneous connect(). Unfortunately, that
> had an impact on TFO and MPTCP.
> 
> I started to look at the impact on MPTCP, because the MPTCP CI found
> some issues with the MPTCP Packetdrill tests [1]. Then Paolo Abeni
> suggested me to look at the impact on TFO with "plain" TCP.
> 
> [...]

Here is the summary with links:
  - [net,v3] tcp: process the 3rd ACK with sk_socket for TFO/MPTCP
    https://git.kernel.org/netdev/net/c/c1668292689a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html