linux-kernel - Re: [POC 2/7] livepatch: Allow to handle lifetime of shadow variables using the livepatch state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.21.2407251329300.21729@pobox.suse.cz>
Date: Thu, 25 Jul 2024 13:31:40 +0200 (CEST)
From: Miroslav Benes <mbenes@...e.cz>
To: Petr Mladek <pmladek@...e.com>
cc: Josh Poimboeuf <jpoimboe@...nel.org>, 
    Joe Lawrence <joe.lawrence@...hat.com>, Nicolai Stange <nstange@...e.de>, 
    live-patching@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [POC 2/7] livepatch: Allow to handle lifetime of shadow variables
 using the livepatch state

> diff --git a/kernel/livepatch/state.c b/kernel/livepatch/state.c
> index 6693d808106b..4ec65afe3a43 100644
> --- a/kernel/livepatch/state.c
> +++ b/kernel/livepatch/state.c
> @@ -198,11 +198,17 @@ void klp_release_states(struct klp_patch *patch)
>  		if (is_state_in_other_patches(patch, state))
>  			continue;
>  
> -		if (!state->callbacks.release)
> -			continue;
> -
> -		if (state->callbacks.setup_succeeded)
> +		if (state->callbacks.release && state->callbacks.setup_succeeded)
>  			state->callbacks.release(patch, state);
> +
> +		if (state->is_shadow)
> +			klp_shadow_free_all(state->id, state->callbacks.shadow_dtor);

The following

> +		/*
> +		 * The @release callback is supposed to restore the original
> +		 * state before the @setup callback was called.
> +		 */
> +		state->callbacks.setup_succeeded = 0;

should go to the previous patch perhaps?

Miroslav