linux-kernel - Re: [PATCH] ptp: Add vDSO-style vmclock support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <603aa858ca961a5c4fdfc9b44834343adf1c73d2.camel@infradead.org>
Date: Thu, 25 Jul 2024 12:53:34 +0100
From: David Woodhouse <dwmw2@...radead.org>
To: "Daniel P." Berrangé <berrange@...hat.com>
Cc: "Michael S. Tsirkin" <mst@...hat.com>, Richard Cochran
 <richardcochran@...il.com>, Peter Hilber <peter.hilber@...nsynergy.com>, 
 linux-kernel@...r.kernel.org, virtualization@...ts.linux.dev, 
 linux-arm-kernel@...ts.infradead.org, linux-rtc@...r.kernel.org, "Ridoux,
 Julien" <ridouxj@...zon.com>, virtio-dev@...ts.linux.dev, "Luu, Ryan"
 <rluu@...zon.com>,  "Chashper, David" <chashper@...zon.com>, "Mohamed
 Abuelfotoh, Hazem" <abuehaze@...zon.com>, "Christopher S . Hall"
 <christopher.s.hall@...el.com>, Jason Wang <jasowang@...hat.com>, John
 Stultz <jstultz@...gle.com>, netdev@...r.kernel.org, Stephen Boyd
 <sboyd@...nel.org>,  Thomas Gleixner <tglx@...utronix.de>, Xuan Zhuo
 <xuanzhuo@...ux.alibaba.com>, Marc Zyngier <maz@...nel.org>,  Mark Rutland
 <mark.rutland@....com>, Daniel Lezcano <daniel.lezcano@...aro.org>,
 Alessandro Zummo <a.zummo@...ertech.it>, Alexandre Belloni
 <alexandre.belloni@...tlin.com>,  qemu-devel <qemu-devel@...gnu.org>, Simon
 Horman <horms@...nel.org>
Subject: Re: [PATCH] ptp: Add vDSO-style vmclock support

On Thu, 2024-07-25 at 12:31 +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 25, 2024 at 10:56:05AM +0100, David Woodhouse wrote:
> > Hi Michael, thanks for the review!
> > 
> > On Thu, 2024-07-25 at 01:48 -0400, Michael S. Tsirkin wrote:
> > > Do you want to just help complete virtio-rtc then? Would be easier than
> > > trying to keep two specs in sync.
> > 
> > The ACPI version is much more lightweight and doesn't take up a
> > valuable PCI slot#. (I know, you can do virtio without PCI but that's
> > complex in other ways).
> 
> In general it shouldn't have to take up a PCI slot, that's just
> a common default policy. virtio-devices only need a dedicated
> slot if there's a need to do hotplug/unplug of them. There is a
> set of core devices for which hotplug doesn't make sense, which
> could all be put as functions in the same slot. ie virtio-rng,
> virtio-balloon and virtio-rtc, could all live in one slot.

But if you don't have any virtio devices already, you still need one
slot to put them in.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5965 bytes)