linux-kernel - Re: [PATCH] tracing: remove tracing_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240725083102.38950c1c@gandalf.local.home>
Date: Thu, 25 Jul 2024 08:31:02 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org, Masami Hiramatsu <mhiramat@...nel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH] tracing: remove tracing_is_on export

On Thu, 25 Jul 2024 11:36:08 +0200
Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:

> The function tracing_is_on() is only called by in-kernel code, not by
> any modules, so no need to export it as a symbol at all.

Hmm, this is part of the debugging code along with:

 tracing_on();  tracing_off();

I had it exported in case a module needed to use it in debugging.

-- Steve


> 
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Masami Hiramatsu <mhiramat@...nel.org>
> Cc: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> ---
>  kernel/trace/trace.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 578a49ff5c32..d09f2effa7a9 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -1612,7 +1612,6 @@ int tracing_is_on(void)
>  {
>  	return tracer_tracing_is_on(&global_trace);
>  }
> -EXPORT_SYMBOL_GPL(tracing_is_on);
>  
>  static int __init set_buf_size(char *str)
>  {