linux-kernel - Re: [PATCH] ALSA: hda: conexant: Fix headset auto detect fail in the polling mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87plr1ipmv.wl-tiwai@suse.de>
Date: Thu, 25 Jul 2024 15:10:16 +0200
From: Takashi Iwai <tiwai@...e.de>
To: soxiebing <soxiebing@....com>
Cc: tiwai@...e.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	songxiebing <songxiebing@...inos.cn>,
	bo liu <bo.liu@...arytech.com>
Subject: Re: [PATCH] ALSA: hda: conexant: Fix headset auto detect fail in the polling mode

On Thu, 25 Jul 2024 10:26:10 +0200,
soxiebing wrote:
> 
> From: songxiebing <songxiebing@...inos.cn>
> 
> 'Fixes: 7aeb25908648 ("Fix headset auto detect fail in cx8070 and SN6140")'

The Fixes tag should be put around Signed-off-by.
Also drop the quote ''.

> This patch only handles the unsol_event reporting during interrupts
> and does not include the polling mode used to set jackroll_ms, so
> it's changed to use snd_hda_jack_detect-enable_callback function.

If you mean about the commit above as "this patch", better to
rephrase to be clearer.

The code change itself looks good, through a quick glance.

Could you try to improve the patch description and resubmit?


thanks,

Takashi