linux-kernel - Re: [PATCH V3 1/2] dt-bindings: iio: Add YAML to Awinic proximity sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87498937-a331-4e80-afec-443f85796776@kernel.org>
Date: Thu, 25 Jul 2024 15:53:00 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: wangshuaijie@...nic.com
Cc: conor+dt@...nel.org, devicetree@...r.kernel.org, jic23@...nel.org,
 kangjiajun@...nic.com, krzk+dt@...nel.org, lars@...afoo.de,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
 liweilei@...nic.com, robh@...nel.org, waqar.hameed@...s.com
Subject: Re: [PATCH V3 1/2] dt-bindings: iio: Add YAML to Awinic proximity
 sensor

On 25/07/2024 14:47, wangshuaijie@...nic.com wrote:
> 
>>> +    $ref: /schemas/types.yaml#/definitions/uint32
>>> +    description:
>>> +      Set the number of the SAR(Specific Absorption Rate) sensor.
>>> +      It is set to 0 if one awinic sar chip is used.
>>> +      If two awinic sar chips are used, awinic,sar-label in the first
>>> +      awinic-sar should be set to 0 and awinic,sar-label in the second
>>> +      awinic-sar should be set to 1.
>>> +      In an application where a device utilizes multiple proximity sensors,
>>> +      it is used to retrieve the names of the register configuration files
>>> +      that the drivers need to load. For example: aw963xx_reg_0.bin/aw963xx_reg_1.bin
>>> +
>>> +  awinic,regulator-power-supply:
>>
>> It does not look like you tested the bindings, at least after quick
>> look. Please run `make dt_binding_check` (see
>> Documentation/devicetree/bindings/writing-schema.rst for instructions).
>> Maybe you need to update your dtschema and yamllint.
>>
> 
> The patch for v4 will fix these issues.

Really? I commented here that you did not test it, so let's look at v4
and see if you tested it.

Best regards,
Krzysztof