linux-kernel - Re: [PATCH V4 1/2] dt-bindings: iio: aw9610x: Add bindings for aw9610x sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9e0e87c-0332-48b3-879d-258ca0fe58ee@kernel.org>
Date: Thu, 25 Jul 2024 15:54:10 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Rob Herring (Arm)" <robh@...nel.org>, wangshuaijie@...nic.com
Cc: waqar.hameed@...s.com, liweilei@...nic.com, lars@...afoo.de,
 linux-iio@...r.kernel.org, kangjiajun@...nic.com, jic23@...nel.org,
 linux-kernel@...r.kernel.org, conor+dt@...nel.org,
 devicetree@...r.kernel.org, krzk+dt@...nel.org
Subject: Re: [PATCH V4 1/2] dt-bindings: iio: aw9610x: Add bindings for
 aw9610x sensor

On 25/07/2024 15:17, Rob Herring (Arm) wrote:
> 
> On Thu, 25 Jul 2024 12:12:51 +0000, wangshuaijie@...nic.com wrote:
>> From: shuaijie wang <wangshuaijie@...nic.com>
>>
>> Add device tree bindings for aw9610x proximity sensor.
>>
>> Signed-off-by: shuaijie wang <wangshuaijie@...nic.com>
>> ---
>>  .../iio/proximity/awinic,aw9610x.yaml         | 61 +++++++++++++++++++
>>  1 file changed, 61 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/iio/proximity/awinic,aw9610x.yaml
>>
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> yamllint warnings/errors:
> 
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/proximity/awinic,aw9610x.yaml: $id: Cannot determine base path from $id, relative path/filename doesn't match actual path or filename
>  	 $id: http://devicetree.org/schemas/input/awinic,aw9610x.yaml
>  	file: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/proximity/awinic,aw9610x.yaml

Look, still not tested.

You got comment on v3 that you must it prior to sending. The comment
also explained how to perform the testing.

You responded that you will implement testing but as easily we can see
here, you still did not test it.

Please, stop wasting our time. TEST your patches BEFORE sending.

Best regards,
Krzysztof