[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240725-prevalent-marry-66670630061f@spud>
Date: Thu, 25 Jul 2024 15:25:33 +0100
From: Conor Dooley <conor@...nel.org>
To: pierre-henry.moussay@...rochip.com
Cc: Conor Dooley <conor.dooley@...rochip.com>,
Daire McNamara <daire.mcnamara@...rochip.com>,
Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
linux-riscv@...ts.infradead.org, linux-gpio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/17] dt-bindings: gpio: mpfs-gpio: Add PIC64GX GPIO
compatibility
On Thu, Jul 25, 2024 at 01:15:57PM +0100, pierre-henry.moussay@...rochip.com wrote:
> From: Pierre-Henry Moussay <pierre-henry.moussay@...rochip.com>
>
> PIC64GX GPIO is compatible with mpfs-gpio driver
>
> Signed-off-by: Pierre-Henry Moussay <pierre-henry.moussay@...rochip.com>
> ---
> .../bindings/gpio/microchip,mpfs-gpio.yaml | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml b/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml
> index d61569b3f15b..fdce88374a91 100644
> --- a/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml
> +++ b/Documentation/devicetree/bindings/gpio/microchip,mpfs-gpio.yaml
> @@ -11,10 +11,14 @@ maintainers:
>
> properties:
> compatible:
> - items:
> - - enum:
> - - microchip,mpfs-gpio
> - - microchip,coregpio-rtl-v3
> + oneOf:
> + - items:
> + - const: microchip,pic64gx-gpio
> + - const: microchip,mpfs-gpio
> + - items:
> + - enum:
> + - microchip,mpfs-gpio
> + - microchip,coregpio-rtl-v3
>
> reg:
> maxItems: 1
> @@ -69,7 +73,9 @@ allOf:
> properties:
> compatible:
> contains:
> - const: microchip,mpfs-gpio
> + enum:
> + - microchip,mpfs-gpio
> + - microchip,pic64gx-gpio
This hunk should not be needed, given you have an mpfs-gpio fallback.
Thanks,
Conor.
> then:
> required:
> - interrupts
> --
> 2.30.2
>
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists