linux-kernel - Re: [PATCH v2] selftests: lib: remove strscpy test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bdd359e-037c-4b7c-84e6-db381a619dcd@linuxfoundation.org>
Date: Thu, 25 Jul 2024 08:45:47 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>,
 Shuah Khan <shuah@...nel.org>, Kees Cook <kees@...nel.org>
Cc: kernel@...labora.com, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] selftests: lib: remove strscpy test

On 7/25/24 06:11, Muhammad Usama Anjum wrote:
> The strscpy test loads test_strscpy module for testing. But test_strscpy
> was converted to Kunit (see fixes). Hence remove strscpy.
> 
> Fixes: 41eefc46a3a4 ("string: Convert strscpy() self-test to KUnit")

Remove fixes tag - this isn't a fix and we don't want this propagating
to stable releases without kunit test for this.

It appears fixes tag is being used too generously for things that
aren't fixes. Let's use it only when it is a real fix.
  
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
> ---

thanks,
-- Shuah