linux-kernel - Re: [PATCH net 0/2] tap/tun: harden by dropping short frame

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <172192075020.10696.12286073908721729622.git-patchwork-notify@kernel.org>
Date: Thu, 25 Jul 2024 15:19:10 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Dongli Zhang <dongli.zhang@...cle.com>
Cc: netdev@...r.kernel.org, willemdebruijn.kernel@...il.com,
 jasowang@...hat.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, ast@...nel.org, daniel@...earbox.net,
 hawk@...nel.org, john.fastabend@...il.com, linux-kernel@...r.kernel.org,
 bpf@...r.kernel.org, si-wei.liu@...cle.com
Subject: Re: [PATCH net 0/2] tap/tun: harden by dropping short frame

Hello:

This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 24 Jul 2024 10:04:50 -0700 you wrote:
> This is to harden all of tap/tun to avoid any short frame smaller than the
> Ethernet header (ETH_HLEN).
> 
> While the xen-netback already rejects short frame smaller than ETH_HLEN ...
> 
>  914 static void xenvif_tx_build_gops(struct xenvif_queue *queue,
>  915                                      int budget,
>  916                                      unsigned *copy_ops,
>  917                                      unsigned *map_ops)
>  918 {
> ... ...
> 1007                 if (unlikely(txreq.size < ETH_HLEN)) {
> 1008                         netdev_dbg(queue->vif->dev,
> 1009                                    "Bad packet size: %d\n", txreq.size);
> 1010                         xenvif_tx_err(queue, &txreq, extra_count, idx);
> 1011                         break;
> 1012                 }
> 
> [...]

Here is the summary with links:
  - [net,1/2] tap: add missing verification for short frame
    https://git.kernel.org/netdev/net/c/ed7f2afdd0e0
  - [net,2/2] tun: add missing verification for short frame
    https://git.kernel.org/netdev/net/c/049584807f1d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html