linux-kernel - Re: [PATCH] tools/nolibc: include arch.h from string.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZqKHVeZg+Tu6VV5f@1wt.eu>
Date: Thu, 25 Jul 2024 19:11:49 +0200
From: Willy Tarreau <w@....eu>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: Ammar Faizi <ammarfaizi2@...weeb.org>,
        Alviro Iskandar Setiawan <alviro.iskandar@...weeb.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] tools/nolibc: include arch.h from string.h

Hi Thomas,

On Thu, Jul 25, 2024 at 06:54:18PM +0200, Thomas Weißschuh wrote:
> string.h tests for the macros NOLIBC_ARCH_HAS_$FUNC to use the
> architecture-optimized function variants.
> However if string.h is included before arch.h header than that check
                                                       ^^^^
then

> does not work, leading to duplicate function definitions.
> 
> Fixes: 553845eebd60 ("tools/nolibc: x86-64: Use `rep movsb` for `memcpy()` and `memmove()`")
> Fixes: 12108aa8c1a1 ("tools/nolibc: x86-64: Use `rep stosb` for `memset()`")
> Cc: stable@...r.kernel.org
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>

Good catch!

Acked-by: Willy Tarreau <w@....eu>

Thanks,
Willy