linux-kernel - Re: [PATCH] nvmem: core: WARN_ONCE on nvmem reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <775f8dd7-75cf-4772-967e-3757c2375ee0@suswa.mountain>
Date: Thu, 25 Jul 2024 12:48:06 -0500
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Joy Chakraborty <joychakr@...gle.com>
Cc: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvmem: core: WARN_ONCE on nvmem reg_read/write()
 returning positive values

On Thu, Jul 25, 2024 at 11:21:26AM +0000, Joy Chakraborty wrote:
> Nvmem core currently expects 0 to be returned on successful read/write
> and negative for failure from nvmem producers.
> Warn incase any nvmem producer returns positive values which might
> happen if any producer ends up returning the number of bytes read or
> written.
> 
> Signed-off-by: Joy Chakraborty <joychakr@...gle.com>

Thanks for fixing all these.  I've double checked and I believe you did
catch them all.  Plus if this patch triggers any warnings, then it will
be annoying but it's better to know about the bugs instead of running
into subtle issues down the road which is what the previous code did.

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter