linux-kernel - [PATCH v4] tools/testing:Fix the wrong format specifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240725023401.13365-1-zhujun2@cmss.chinamobile.com>
Date: Wed, 24 Jul 2024 19:34:01 -0700
From: Zhu Jun <zhujun2@...s.chinamobile.com>
To: zhang.lyra@...il.com
Cc: shuah@...nel.org,
	kees@...nel.org,
	luto@...capital.net,
	wad@...omium.org,
	linux-kselftest@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	zhujun2@...s.chinamobile.com
Subject: [PATCH v4] tools/testing:Fix the wrong format specifier

The format specifier in fprintf is "%u", that "%u" should use
unsigned int type instead.the problem is discovered by reading code.

Signed-off-by: Zhu Jun <zhujun2@...s.chinamobile.com>
---
 v1->v2:
 	modify commit info add how to find the problem in the log
 v2->v3:
 	Seems this can use macro WTERMSIG like those above usage, rather than
 	changing the print format.
 v3->v4:
 	Now the commit summary doesn't match the change you are making.
	 Also WTERMSIG() is incorrect for this conditional code path.
	 See comments below in the code path.

	 I would leave the v2 code intact. How are you testing this change?
	 Please include the details in the change log.


 tools/testing/selftests/kselftest_harness.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h
index e05ac8261046..675b8f43e148 100644
--- a/tools/testing/selftests/kselftest_harness.h
+++ b/tools/testing/selftests/kselftest_harness.h
@@ -910,7 +910,7 @@ void __wait_for_test(struct __test_metadata *t)
 		.sa_flags = SA_SIGINFO,
 	};
 	struct sigaction saved_action;
-	int status;
+	unsigned int status;
 
 	if (sigaction(SIGALRM, &action, &saved_action)) {
 		t->passed = 0;
-- 
2.17.1