linux-kernel - Re: [PATCH 0/7] minmax: reduce compilation time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d73c9de5-7f18-41dc-870f-575ec59d50a1@kernel.dk>
Date: Fri, 26 Jul 2024 15:46:41 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Linus Torvalds <torvalds@...uxfoundation.org>,
 Lorenzo Stoakes <lorenzo.stoakes@...cle.com>
Cc: David Laight <David.Laight@...lab.com>,
 "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "Matthew Wilcox (Oracle)" <willy@...radead.org>,
 Christoph Hellwig <hch@...radead.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Dan Carpenter <dan.carpenter@...aro.org>, Arnd Bergmann <arnd@...nel.org>,
 "Jason@...c4.com" <Jason@...c4.com>,
 "pedro.falcato@...il.com" <pedro.falcato@...il.com>,
 Mateusz Guzik <mjguzik@...il.com>, "linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [PATCH 0/7] minmax: reduce compilation time

On 7/26/24 3:36 PM, Linus Torvalds wrote:
> Now, fixing that, and you end up with
> 
>   Longest line is 61861 (82kB)
> 
> so it's now "only" 82kB in size, and that actually comes from
> <linux/bio.h>, which has this:
> 
>    static inline unsigned bio_segments(struct bio *bio)
>    {
>    ...
>         bio_for_each_segment(bv, bio, iter)
>                 segs++;
> 
> which looks very tame indeed, but it turns out that
> "bio_for_each_segment()" expands to 82kB of code.
> 
> Jens? Maybe time to look into this?

Eek yes, that looks horrible. I'll take a look.

-- 
Jens Axboe