linux-kernel - Re: [PATCH] power: supply: qcom_battmgr: return EAGAIN when firmware service is not up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <172203355443.246603.13662219731890792931.b4-ty@collabora.com>
Date: Sat, 27 Jul 2024 00:39:14 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Sebastian Reichel <sre@...nel.org>, 
 Bjorn Andersson <andersson@...nel.org>, 
 Neil Armstrong <neil.armstrong@...aro.org>
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>, 
 "Rafael J. Wysocki" <rjw@...ysocki.net>, linux-arm-msm@...r.kernel.org, 
 linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, 
 stable@...r.kernel.org
Subject: Re: [PATCH] power: supply: qcom_battmgr: return EAGAIN when
 firmware service is not up

On Mon, 15 Jul 2024 14:57:06 +0200, Neil Armstrong wrote:
> The driver returns -ENODEV when the firmware battmrg service hasn't
> started yet, while per-se -ENODEV is fine, we usually use -EAGAIN to
> tell the user to retry again later. And the power supply core uses
> -EGAIN when the device isn't initialized, let's use the same return.
> 
> This notably causes an infinite spam of:
> thermal thermal_zoneXX: failed to read out thermal zone (-19)
> because the thermal core doesn't understand -ENODEV, but only
> considers -EAGAIN as a non-fatal error.
> 
> [...]

Applied, thanks!

[1/1] power: supply: qcom_battmgr: return EAGAIN when firmware service is not up
      commit: bf9d5cb588755ee41ac12a8976dccf44ae18281b

Best regards,
-- 
Sebastian Reichel <sebastian.reichel@...labora.com>