[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <li2dwzrd7oqjc4rmkrimicmbkzh46grpt2pwjbidsksm4xbtx7@ifc3ir4ineo5>
Date: Thu, 25 Jul 2024 20:36:13 -0400
From: Alex Lanzano <lanzano.alex@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: mehdi.djait@...tlin.com,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display: Add Sharp Memory LCD bindings
On Thu, Jul 25, 2024 at 08:18:44AM GMT, Krzysztof Kozlowski wrote:
> On 25/07/2024 02:47, Alex Lanzano wrote:
> > Add device tree bindings for the monochrome Sharp Memory LCD
> >
> > Signed-off-by: Alex Lanzano <lanzano.alex@...il.com>
> > ---
> > .../bindings/display/sharp,sharp-memory.yaml | 97 +++++++++++++++++++
> > include/dt-bindings/display/sharp-memory.h | 9 ++
> > 2 files changed, 106 insertions(+)
>
> BTW, look at your original binding:
> https://lore.kernel.org/dri-devel/2a7c51b6e619c02ec175a5c219b0a0fd7a24499d.1701267411.git.mehdi.djait@bootlin.com/
>
> Why did you decide to introduce mistakes? Eg. dropping all $refs?
>
> And finally look at the comment:
> https://lore.kernel.org/dri-devel/5dbdf7bd-cfa3-492b-a0a3-fdc323cf11f8@linaro.org/
> You just ignored it completely....
>
> Best regards,
> Krzysztof
>
Will fix in V2.
Best regards,
Alex
Powered by blists - more mailing lists