linux-kernel - Re: [PATCH] ALSA: hda: conexant: Fix headset auto detect fail in the polling mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240726094156.48571-1-soxiebing@163.com>
Date: Fri, 26 Jul 2024 17:41:56 +0800
From: soxiebing <soxiebing@....com>
To: tiwai@...e.com
Cc: linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda: conexant: Fix headset auto detect fail in the polling mode

>On Fri, 26 Jul 2024 03:23:42 +0200,
>soxiebing wrote:
>> 
>> From: songxiebing <songxiebing@...inos.cn>
>> 
>> This patch(7aeb25908648) only handles the unsol_event reporting during
>
>It should be rather "The previous fix (7aeb25908648)".  "This" points
>the very patch you send now :)
>
>> interrupts and does not include the polling mode used to set jackroll_ms,
>> so now we are replacing it with snd_hda_jack_detect_enable_callback.
>> 
>> Fixes: 7aeb25908648 ("Fix headset auto detect fail in cx8070 and SN6140")
>
>Don't drop "ALSA: hda/conexant:" prefix but copy the full subject line.
>
>> Co-developed-by: bo liu <bo.liu@...arytech.com>
>
>Usually Co-developed-by is followed by a Signed-off-by of that
>author.
>
>> Signed-off-by: songxiebing <songxiebing@...inos.cn>
>
>And, I noticed a typo in the patch that broke the compilation:
>
>> -static void cx_update_headset_mic_vref(struct hda_codec *codec, unsigned int res)
>> +static void cx_update_headset_mic_vref(struct hda_codec *codec, struct hda_jack_callback *event)
>>  {
>> -	unsigned int phone_present, mic_persent, phone_tag, mic_tag;
>> -	struct conexant_spec *spec = codec->spec;
>> +	unsigned int mic_persent;
>
>... here.
>
>Please make sure that the patch really works before submission.
>Also, run scripts/checkpatch.pl for checking the coding style and the
>patch formalities.
>
Sorry, just a mistake, i ensure that this patch is validated.
>
>
>thanks,
>
>Takashi
--
Thanks,

soxiebing