linux-kernel - Re: [PATCH RFC v3 1/9] spi: dt-bindings: add spi-offload properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240726114755.GA985744-robh@kernel.org>
Date: Fri, 26 Jul 2024 06:47:55 -0500
From: Rob Herring <robh@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Mark Brown <broonie@...nel.org>, Jonathan Cameron <jic23@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Nuno Sá <nuno.sa@...log.com>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	David Jander <david@...tonic.nl>,
	Martin Sperl <kernel@...tin.sperl.org>, linux-spi@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-iio@...r.kernel.org
Subject: Re: [PATCH RFC v3 1/9] spi: dt-bindings: add spi-offload properties

On Mon, Jul 22, 2024 at 04:57:08PM -0500, David Lechner wrote:
> This adds a new provider/consumer property pair to the generic SPI
> bindings for use with peripherals connected to controllers that support
> offloading.
> 
> Here, offloading means that the controller has the ability to perform
> SPI transactions without any CPU intervention in some shape or form.
> 
> The spi-offloads property will be used to assign controller offload
> resources to each peripheral that needs them. What these resources are
> will be defined by each specific controller binding by specifying the
> value of the #spi-offload-cells property.
> 
> SPI peripherals that use multiple offload instances at the same time
> for different functions can describe the functions using the
> spi-offload-names property, for example, for a SPI flash memory, this
> might be "read", "erase" and "write" functions.
> 
> Signed-off-by: David Lechner <dlechner@...libre.com>
> ---
> 
> v3 changes:
> * Added #spi-offload-cells property to the controller binding.
> * Changed spi-offloads to phandle-array.
> * Added spi-offload-names property.
> 
> v2 changes:
> 
> In v1, instead of generic SPI bindings, there were only controller-
> specific bindings, so this is a new patch.
> ---
>  Documentation/devicetree/bindings/spi/spi-controller.yaml     |  5 +++++
>  .../devicetree/bindings/spi/spi-peripheral-props.yaml         | 11 +++++++++++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-controller.yaml b/Documentation/devicetree/bindings/spi/spi-controller.yaml
> index 093150c0cb87..0af9cce80be9 100644
> --- a/Documentation/devicetree/bindings/spi/spi-controller.yaml
> +++ b/Documentation/devicetree/bindings/spi/spi-controller.yaml
> @@ -105,6 +105,11 @@ properties:
>      required:
>        - compatible
>  
> +  '#spi-offload-cells':
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      Number of cells in a SPI offload specifier.
> +

This is the SPI controller/bus schema, but this is likely not part of 
the SPI controller. So needs its own schema.

Some description around what you think would typically be in these cells 
would be good.

Rob