linux-kernel - Re: [PATCH printk v3 02/19] printk: nbcon: Consolidate alloc() and init()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZqOPcW9_4-uXEgez@pathway.suse.cz>
Date: Fri, 26 Jul 2024 13:58:41 +0200
From: Petr Mladek <pmladek@...e.com>
To: John Ogness <john.ogness@...utronix.de>
Cc: Sergey Senozhatsky <senozhatsky@...omium.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH printk v3 02/19] printk: nbcon: Consolidate alloc() and
 init()

On Mon 2024-07-22 19:25:22, John Ogness wrote:
> Rather than splitting the nbcon allocation and initialization into
> two pieces, perform all initialization in nbcon_alloc(). Later,
> the init_seq is calculated and can be explicitly set using
> nbcon_seq_force(). This removes the need for the strong rules of
> nbcon_init() that even included a BUG_ON(). It also more closely
> matches the setup logic of the legacy consoles.
> 
> Signed-off-by: John Ogness <john.ogness@...utronix.de>

I like this.

Reviewed-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr