linux-kernel - Re: [PATCH v5 1/1] scsi: ufs: core: Support Updating UIC Command Timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ed78d10b8083b32387116d19ef1d3dc3066a881c.camel@mediatek.com>
Date: Fri, 26 Jul 2024 02:09:31 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "quic_nguyenb@...cinc.com" <quic_nguyenb@...cinc.com>,
	"quic_nitirawa@...cinc.com" <quic_nitirawa@...cinc.com>,
	"avri.altman@....com" <avri.altman@....com>, "bvanassche@....org"
	<bvanassche@....org>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>, "manivannan.sadhasivam@...aro.org"
	<manivannan.sadhasivam@...aro.org>, "minwoo.im@...sung.com"
	<minwoo.im@...sung.com>, "quic_cang@...cinc.com" <quic_cang@...cinc.com>,
	"adrian.hunter@...el.com" <adrian.hunter@...el.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"alim.akhtar@...sung.com" <alim.akhtar@...sung.com>, "jejb@...ux.ibm.com"
	<jejb@...ux.ibm.com>, "beanhuo@...ron.com" <beanhuo@...ron.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"quic_mnaresh@...cinc.com" <quic_mnaresh@...cinc.com>
Subject: Re: [PATCH v5 1/1] scsi: ufs: core: Support Updating UIC Command
 Timeout

On Tue, 2024-07-23 at 20:49 -0700, Bao D. Nguyen wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  The default UIC command timeout still remains 500ms.
> Allow platform drivers to override the UIC command
> timeout if desired.
> 
> In a real product, the 500ms timeout value is probably good enough.
> However, during the product development where there are a lot of
> logging and debug messages being printed to the uart console,
> interrupt starvations happen occasionally because the uart may
> print long debug messages from different modules in the system.
> While printing, the uart may have interrupts disabled for more
> than 500ms, causing UIC command timeout.
> The UIC command timeout would trigger more printing from
> the UFS driver, and eventually a watchdog timeout may
> occur unnecessarily.
> 
> Add support for overriding the UIC command timeout value
> with the newly created uic_cmd_timeout kernel module parameter.
> Default value is 500ms. Supported values range from 500ms
> to 2 seconds.
> 
> Signed-off-by: Bao D. Nguyen <quic_nguyenb@...cinc.com>
> Suggested-by: Bart Van Assche <bvanassche@....org>
> Reviewed-by: Bart Van Assche <bvanassche@....org>
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> ---
>  drivers/ufs/core/ufshcd.c | 29 ++++++++++++++++++++++++-----
>  1 file changed, 24 insertions(+), 5 deletions(-)
> 

Reviewed-by: Peter Wang <peter.wang@...iatek.com>