linux-kernel - Re: [PATCH] perf daemon: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZqOvLekXEZgu6Hqo@x1>
Date: Fri, 26 Jul 2024 11:14:05 -0300
From: Arnaldo Carvalho de Melo <acme@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: Chen Ni <nichen@...as.ac.cn>, peterz@...radead.org, mingo@...hat.com,
	namhyung@...nel.org, mark.rutland@....com,
	alexander.shishkin@...ux.intel.com, jolsa@...nel.org,
	adrian.hunter@...el.com, kan.liang@...ux.intel.com,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf daemon: Convert comma to semicolon

On Tue, Jul 16, 2024 at 06:33:34AM -0700, Ian Rogers wrote:
> On Tue, Jul 16, 2024 at 12:46 AM Chen Ni <nichen@...as.ac.cn> wrote:
> >
> > Replace a comma between expression statements by a semicolon.
> >
> > Fixes: 2d6914cd59ff ("perf daemon: Add 'signal' command")
> > Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> 
> Reviewed-by: Ian Rogers <irogers@...gle.com>

Thanks, applied to tmp.perf-tools-next, and also removed the fixes tag.

- Arnaldo
 
> Thanks,
> Ian
> 
> > ---
> >  tools/perf/builtin-daemon.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-daemon.c b/tools/perf/builtin-daemon.c
> > index de76bbc50bfb..18f7f417ba11 100644
> > --- a/tools/perf/builtin-daemon.c
> > +++ b/tools/perf/builtin-daemon.c
> > @@ -1433,7 +1433,7 @@ static int __cmd_signal(struct daemon *daemon, struct option parent_options[],
> >         }
> >
> >         memset(&cmd, 0, sizeof(cmd));
> > -       cmd.signal.cmd = CMD_SIGNAL,
> > +       cmd.signal.cmd = CMD_SIGNAL;
> >         cmd.signal.sig = SIGUSR2;
> >         strncpy(cmd.signal.name, name, sizeof(cmd.signal.name) - 1);
> >
> > --
> > 2.25.1
> >