linux-kernel - Re: [PATCH] tracing: remove tracing_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240726102208.41996fbf@rorschach.local.home>
Date: Fri, 26 Jul 2024 10:22:08 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org, Masami Hiramatsu <mhiramat@...nel.org>,
 Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [PATCH] tracing: remove tracing_is_on export

On Fri, 26 Jul 2024 10:15:14 +0200
Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:

> > This has been exported since 2008. Has it ever been a problem in the last
> > 16 years?  
> 
> As I am finding out, yes, external modules are "abusing" this to do
> different types of logic depending on if tracing is enabled or not for
> various unknown reasons.  As there was no in-kernel user of this symbol,
> I assumed it was just an oversight and should be removed.
> 
> I'll go ask the distro involved to just remove the symbol from their
> kernels instead, but that feels like the wrong thing to do to me.

Interesting as I was unaware of this. I'm not against removing the
"is_on" from being exported, as that really was only there to be
consistent with the others.

-- Steve