linux-kernel - Re: [linus:master] [tcp] 23e89e8ee7: packetdrill.packetdrill/gtests/net/tcp/fastopen/client/simultaneous-fast-open

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADVnQynLaT0rGcLDBB+T237x6aHx7K74kNPZz4hLFTK7U=CVwA@mail.gmail.com>
Date: Fri, 26 Jul 2024 10:39:51 -0400
From: Neal Cardwell <ncardwell@...gle.com>
To: Eric Dumazet <edumazet@...gle.com>
Cc: kernel test robot <oliver.sang@...el.com>, Kuniyuki Iwashima <kuniyu@...zon.com>, oe-lkp@...ts.linux.dev, 
	lkp@...el.com, linux-kernel@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>, 
	netdev@...r.kernel.org, Matthieu Baerts <matttbe@...nel.org>
Subject: Re: [linus:master] [tcp] 23e89e8ee7: packetdrill.packetdrill/gtests/net/tcp/fastopen/client/simultaneous-fast-open_ipv4-mapped-v6.fail

On Thu, Jul 25, 2024 at 4:07 AM Eric Dumazet <edumazet@...gle.com> wrote:
>
> On Thu, Jul 25, 2024 at 6:55 AM kernel test robot <oliver.sang@...el.com> wrote:
> >
> >
> >
> > Hello,
> >
> > kernel test robot noticed "packetdrill.packetdrill/gtests/net/tcp/fastopen/client/simultaneous-fast-open_ipv4-mapped-v6.fail" on:
> >
> > commit: 23e89e8ee7be73e21200947885a6d3a109a2c58d ("tcp: Don't drop SYN+ACK for simultaneous connect().")
> > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> >
> > [test failed on linus/master      68b59730459e5d1fe4e0bbeb04ceb9df0f002270]
> > [test failed on linux-next/master 73399b58e5e5a1b28a04baf42e321cfcfc663c2f]
> >
> > in testcase: packetdrill
> > version: packetdrill-x86_64-31fbbb7-1_20240226
> > with following parameters:
> >
> >
> > compiler: gcc-13
> > test machine: 16 threads 1 sockets Intel(R) Xeon(R) E-2278G CPU @ 3.40GHz (Coffee Lake) with 32G memory
> >
> > (please refer to attached dmesg/kmsg for entire log/backtrace)
> >
> >
> > we also noticed other failed cases that can pass on parent.
> >
> >
> > 42ffe242860c401c 23e89e8ee7be73e21200947885a
> > ---------------- ---------------------------
> >        fail:runs  %reproduction    fail:runs
> >            |             |             |
> >            :9           67%           6:6     packetdrill.packetdrill/gtests/net/tcp/fastopen/client/simultaneous-fast-open_ipv4-mapped-v6.fail
> >            :9           67%           6:6     packetdrill.packetdrill/gtests/net/tcp/fastopen/client/simultaneous-fast-open_ipv4.fail
> >            :9           67%           6:6     packetdrill.packetdrill/gtests/net/tcp/fastopen/client/simultaneous-fast-open_ipv6.fail
> >            :9           67%           6:6     packetdrill.packetdrill/gtests/net/tcp/fastopen/server/basic-cookie-not-reqd_ipv4-mapped-v6.fail
> >            :9           67%           6:6     packetdrill.packetdrill/gtests/net/tcp/fastopen/server/basic-cookie-not-reqd_ipv4.fail
> >            :9           67%           6:6     packetdrill.packetdrill/gtests/net/tcp/fastopen/server/basic-zero-payload_ipv4-mapped-v6.fail
> >            :9           67%           6:6     packetdrill.packetdrill/gtests/net/tcp/fastopen/server/basic-zero-payload_ipv4.fail
> >            :9           67%           6:6     packetdrill.packetdrill/gtests/net/tcp/fastopen/server/opt34/basic-cookie-not-reqd_ipv4-mapped-v6.fail
> >            :9           67%           6:6     packetdrill.packetdrill/gtests/net/tcp/fastopen/server/opt34/basic-cookie-not-reqd_ipv4.fail
> >            :9           67%           6:6     packetdrill.packetdrill/gtests/net/tcp/fastopen/server/opt34/basic-zero-payload_ipv4-mapped-v6.fail
> >            :9           67%           6:6     packetdrill.packetdrill/gtests/net/tcp/fastopen/server/opt34/basic-zero-payload_ipv4.fail
> >
> >
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <oliver.sang@...el.com>
> > | Closes: https://lore.kernel.org/oe-lkp/202407251053.618edf56-oliver.sang@intel.com
> >
> >
> >
> > FAIL [/lkp/benchmarks/packetdrill/gtests/net/tcp/fastopen/client/simultaneous-fast-open.pkt (ipv6)]
> >
> > ...
> >
> > FAIL [/lkp/benchmarks/packetdrill/gtests/net/tcp/fastopen/client/simultaneous-fast-open.pkt (ipv4)]
> >
> > ...
> >
> > FAIL [/lkp/benchmarks/packetdrill/gtests/net/tcp/fastopen/client/simultaneous-fast-open.pkt (ipv4-mapped-v6)]
> >
> > ...
> >
> >
> > The kernel config and materials to reproduce are available at:
> > https://download.01.org/0day-ci/archive/20240725/202407251053.618edf56-oliver.sang@intel.com
> >
> >
> >
> > --
> > 0-DAY CI Kernel Test Service
> > https://github.com/intel/lkp-tests/wiki
> >
>
> This has been discussed recently in netdev mailing list, one ACK will
> get more precise information.

This should be fixed from this packetdrill test update from Matthieu
Baerts that I just merged:
  https://github.com/google/packetdrill/pull/87

(For our internal versions of the tests, Eric provided an equivalent patch.)

neal