linux-kernel - Re: [PATCH] staging: media: omap4iss: add check for media_pad_remote_pad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f61bbcf4-ca29-44c7-bd27-3261781a1a91@suswa.mountain>
Date: Fri, 26 Jul 2024 11:05:27 -0500
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Chen Ni <nichen@...as.ac.cn>
Cc: laurent.pinchart@...asonboard.com, mchehab@...nel.org,
	gregkh@...uxfoundation.org, sakari.ailus@...ux.intel.com,
	hverkuil-cisco@...all.nl, linux-media@...r.kernel.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: media: omap4iss: add check for
 media_pad_remote_pad_first

On Fri, Jul 26, 2024 at 03:28:14PM +0800, Chen Ni wrote:
> Add check for the return value of media_pad_remote_pad_first() and
> return the error if it fails in order to avoid NULL pointer dereference.
> 
> Fixes: b2e44430b634 ("media: mc-entity: Rename media_entity_remote_pad() to media_pad_remote_pad_first()")

That Fixes tag isn't correct.  The patch just renamed the function.

When I look at that patch, the isp_pipeline_is_last() function doesn't
check for NULL either.  Why is that one different?

regards,
dan carpenter