lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <87ikwsun8h.ffs@tglx>
Date: Fri, 26 Jul 2024 18:33:34 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: ChengChaoChun <abc21531050@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] linux/interrupt.h: fix struct irqaction comment order
 inconsistency

On Tue, Jul 09 2024 at 00:06, ChengChaoChun wrote:
>  /**
>   * struct irqaction - per interrupt action descriptor
> - * @handler:	interrupt handler function
> - * @name:	name of the device
> - * @dev_id:	cookie to identify the device
> - * @percpu_dev_id:	cookie to identify the device
> - * @next:	pointer to the next irqaction for shared interrupts
> - * @irq:	interrupt number
> - * @flags:	flags (see IRQF_* above)
> - * @thread_fn:	interrupt handler function for threaded interrupts
> - * @thread:	thread pointer for threaded interrupts
> - * @secondary:	pointer to secondary irqaction (force threading)
> - * @thread_flags:	flags related to @thread
> - * @thread_mask:	bitmask for keeping track of @thread activity
> - * @dir:	pointer to the proc/irq/NN/name entry
> + * @handler:    interrupt handler function

This changes tabs to spaces ....

> + * @dev_id:     cookie to identify the device
> + * @percpu_dev_id:      cookie to identify the device
> + * @next:       pointer to the next irqaction for shared interrupts
> + * @thread_fn:  interrupt handler function for threaded interrupts
> + * @thread:     thread pointer for threaded interrupts
> + * @secondary:  pointer to secondary irqaction (force threading)
> + * @irq:        interrupt number
> + * @flags:      flags (see IRQF_* above)
> + * @thread_flags:       flags related to @thread
> + * @thread_mask:        bitmask for keeping track of @thread activity

And while at it, please align all members in a tabular fashion.

Thanks,

        tglx

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ