linux-kernel - Re: [PATCH v2] PCI: Fix crash during pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_JsqJAuVexFAz6gWWuTtX1Go-FnHe6vJapv0znHBERSCtv+Q@mail.gmail.com>
Date: Fri, 26 Jul 2024 12:52:46 -0500
From: Rob Herring <robh@...nel.org>
To: Lizhi Hou <lizhi.hou@....com>
Cc: linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org, 
	devicetree@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org, 
	kvm-ppc@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>, 
	Saravana Kannan <saravanak@...gle.com>, Vaibhav Jain <vaibhav@...ux.ibm.com>, 
	Nicholas Piggin <npiggin@...il.com>, Michael Ellerman <mpe@...erman.id.au>, 
	Vaidyanathan Srinivasan <svaidy@...ux.ibm.com>, Kowshik Jois B S <kowsjois@...ux.ibm.com>, 
	Lukas Wunner <lukas@...ner.de>
Subject: Re: [PATCH v2] PCI: Fix crash during pci_dev hot-unplug on pseries
 KVM guest

On Thu, Jul 25, 2024 at 6:06 PM Lizhi Hou <lizhi.hou@....com> wrote:
>
> Hi Amit,
>
>
> I try to follow the option which add a OF flag. If Rob is ok with this,
> I would suggest to use it instead of V1 patch
>
> diff --git a/drivers/of/dynamic.c b/drivers/of/dynamic.c
> index dda6092e6d3a..a401ed0463d9 100644
> --- a/drivers/of/dynamic.c
> +++ b/drivers/of/dynamic.c
> @@ -382,6 +382,11 @@ void of_node_release(struct kobject *kobj)
>                                 __func__, node);
>          }
>
> +       if (of_node_check_flag(node, OF_CREATED_WITH_CSET)) {
> +               of_changeset_revert(node->data);
> +               of_changeset_destroy(node->data);
> +       }

What happens if multiple nodes are created in the changeset?

> +
>          if (node->child)
>                  pr_err("ERROR: %s() unexpected children for %pOF/%s\n",
>                          __func__, node->parent, node->full_name);
> @@ -507,6 +512,7 @@ struct device_node *of_changeset_create_node(struct
> of_changeset *ocs,
>          np = __of_node_dup(NULL, full_name);
>          if (!np)
>                  return NULL;
> +       of_node_set_flag(np, OF_CREATED_WITH_CSET);

This should be set where the data ptr is set.

Rob