linux-kernel - Re: [PATCH v5 02/12] dt-bindings: usb: ti,j721e-usb: add ti,j7200-usb compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <172202197161.1924212.4114467370508864411.robh@kernel.org>
Date: Fri, 26 Jul 2024 14:26:11 -0500
From: "Rob Herring (Arm)" <robh@...nel.org>
To: Théo Lebrun <theo.lebrun@...tlin.com>
Cc: Mathias Nyman <mathias.nyman@...el.com>, linux-usb@...r.kernel.org, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Kevin Hilman <khilman@...nel.org>, 
 Grégory Clement <gregory.clement@...tlin.com>, 
 devicetree@...r.kernel.org, Tero Kristo <kristo@...nel.org>, 
 linux-kernel@...r.kernel.org, 
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
 linux-arm-kernel@...ts.infradead.org, Nishanth Menon <nm@...com>, 
 Vignesh Raghavendra <vigneshr@...com>, Pawel Laszczak <pawell@...ence.com>, 
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
 Roger Quadros <rogerq@...nel.org>, Peter Chen <peter.chen@...nel.org>, 
 Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v5 02/12] dt-bindings: usb: ti,j721e-usb: add
 ti,j7200-usb compatible


On Fri, 26 Jul 2024 20:17:50 +0200, Théo Lebrun wrote:
> On J7200, the controller & its wrapper are reset on resume. It has the
> same behavior as ti,j721e-usb with a different SoC integration.
> 
> Signed-off-by: Théo Lebrun <theo.lebrun@...tlin.com>
> ---
>  Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml: properties:compatible:oneOf:1:items: 'oneOf' conditional failed, one must be fixed:
	[{'enum': [{'const': 'ti,am64-usb'}, {'const': 'ti,j7200-usb'}]}, {'const': 'ti,j721e-usb'}] is not of type 'object'
	/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml: properties:compatible:oneOf:1:items:0:enum: 'oneOf' conditional failed, one must be fixed:
		{'const': 'ti,am64-usb'} is not of type 'integer'
		{'const': 'ti,am64-usb'} is not of type 'string'
		{'const': 'ti,j7200-usb'} is not of type 'integer'
		{'const': 'ti,j7200-usb'} is not of type 'string'
		hint: "enum" must be an array of either integers or strings
		from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
	from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/ti,j721e-usb.yaml: properties:compatible:oneOf:1:items: 'oneOf' conditional failed, one must be fixed:
	[{'enum': [{'const': 'ti,am64-usb'}, {'const': 'ti,j7200-usb'}]}, {'const': 'ti,j721e-usb'}] is not of type 'object'
	{'const': 'ti,am64-usb'} is not of type 'string'
	{'const': 'ti,j7200-usb'} is not of type 'string'
	from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240726-s2r-cdns-v5-2-8664bfb032ac@bootlin.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.