linux-kernel - Re: [PATCH -next] cgroup/cpuset: reduce redundant comparisons for generating shecd domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62b0b761-37bf-4ae8-9eef-9ac275e99d6c@huawei.com>
Date: Sat, 27 Jul 2024 15:26:10 +0800
From: chenridong <chenridong@...wei.com>
To: Michal Koutný <mkoutny@...e.com>
CC: <tj@...nel.org>, <lizefan.x@...edance.com>, <hannes@...xchg.org>,
	<longman@...hat.com>, <adityakali@...gle.com>, <sergeh@...nel.org>,
	<bpf@...r.kernel.org>, <cgroups@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] cgroup/cpuset: reduce redundant comparisons for
 generating shecd domains



On 2024/7/26 19:37, Michal Koutný wrote:
> Hello.
> 
> On Fri, Jul 26, 2024 at 08:59:46AM GMT, Chen Ridong <chenridong@...wei.com> wrote:
>> In the generate_sched_domains function, it's unnecessary to start the
>> second for loop with zero, which leads redundant comparisons.
>> Simply start with i+1, as that is sufficient.
> 
> Please see
> https://lore.kernel.org/r/20240704062444.262211-1-xavier_qy@163.com
> 
> Your patch is likely obsoleted with that.
> 
> Michal

Thanks, Michal, I'm sorry I didn't notice these patches. It's a good 
idea to optimize with uf_node.

Thanks
Ridong