linux-kernel - Re: [PATCH] irqchip/gic-v3: Remove asmlinkage for gic_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <861q3f2n4e.wl-maz@kernel.org>
Date: Sat, 27 Jul 2024 10:35:45 +0100
From: Marc Zyngier <maz@...nel.org>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: <tglx@...utronix.de>,
	<joey.gouly@....com>,
	<mark.rutland@....com>,
	<will@...nel.org>,
	<catalin.marinas@....com>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] irqchip/gic-v3: Remove asmlinkage for gic_handle_irq()

On Sat, 27 Jul 2024 08:36:48 +0100,
Jinjie Ruan <ruanjinjie@...wei.com> wrote:
> 
> Since commit 064dbfb41691 ("arm64: entry: convert IRQ+FIQ handlers to C"),
> the gic_handle_irq() is only called by C functions, so remove
> the asmlinkage.

You clearly haven't looked very far.

> 
> Fixes: 064dbfb41691 ("arm64: entry: convert IRQ+FIQ handlers to C")
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>
> ---
>  drivers/irqchip/irq-gic-v3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-gic-v3.c b/drivers/irqchip/irq-gic-v3.c
> index c19083bfb943..0efa3443c323 100644
> --- a/drivers/irqchip/irq-gic-v3.c
> +++ b/drivers/irqchip/irq-gic-v3.c
> @@ -930,7 +930,7 @@ static void __gic_handle_irq_from_irqsoff(struct pt_regs *regs)
>  	__gic_handle_nmi(irqnr, regs);
>  }
>  
> -static asmlinkage void __exception_irq_entry gic_handle_irq(struct pt_regs *regs)
> +static void __exception_irq_entry gic_handle_irq(struct pt_regs *regs)
>  {
>  	if (unlikely(gic_supports_nmi() && !interrupts_enabled(regs)))
>  		__gic_handle_irq_from_irqsoff(regs);

$ git grep handle_arch_irq arch/arm/
arch/arm/kernel/entry-armv.S:   bl      generic_handle_arch_irq
arch/arm/kernel/entry-armv.S:   mov_l   r0, generic_handle_arch_irq

Until someone rewrites 32bit ARM to have all of its low-level
interrupt handling in C, this stays. This has no effect on arm64
anyway.

	M.

-- 
Without deviation from the norm, progress is not possible.