linux-kernel - Re: [PATCH 0/6] ASoC: codecs: wcd93xx/wsa88xx: Correct Soundwire ports mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <kggm3zlkevqw3lelxukz5lyfch3vd4uxta3gi7kcidacpo7uz2@hlqq73saz27c>
Date: Sat, 27 Jul 2024 13:55:40 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, 
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>, 
	Mohammad Rafi Shaik <quic_mohs@...cinc.com>, Prasad Kumpatla <quic_pkumpatl@...cinc.com>, 
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Banajit Goswami <bgoswami@...cinc.com>, Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>, 
	linux-sound@...r.kernel.org, linux-kernel@...r.kernel.org, alsa-devel@...a-project.org, 
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH 0/6] ASoC: codecs: wcd93xx/wsa88xx: Correct Soundwire
 ports mask

On Fri, Jul 26, 2024 at 04:10:40PM GMT, Krzysztof Kozlowski wrote:
> Hi,
> 
> Incorrect mask of Soundwire ports - one bit too long/big - was passed.
> 
> Theoretically, too wide mask could cause an out of bounds read in
> sdw_get_slave_dpn_prop() in stream.c, however only in the case of buggy
> driver, e.g. adding incorrect number of ports via
> sdw_stream_add_slave().

Well, granted that sdw_stream_add_slave() crashes on RB3, we know that
the driver is buggy.

> Not adding Cc-stable because I don't think the issue can lead to real
> out-of-bounds read.

-- 
With best wishes
Dmitry